Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go toolchain to 1.23.3 #147

Closed
wants to merge 2 commits into from
Closed

Bump go toolchain to 1.23.3 #147

wants to merge 2 commits into from

Conversation

samuelbartels20
Copy link
Contributor

Please review

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: samuelbartels20
Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spurin and others added 2 commits November 10, 2024 14:09
@spurin @samuelbartels20
check file exists before using bolt.Open
98f8f96 
Signed-off-by: James Spurin <[email protected]>
Signed-off-by: samuelbartels20 <[email protected]>
@samuelbartels20
Bump go toolchain to 1.23.3
3900197 
Signed-off-by: samuelbartels20 <[email protected]>
jmhbnz
jmhbnz requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @samuelbartels20 thanks for raising this. It looks like your starting branch was not completely clean / up to date as there are two commits showing and there are some unrelated changes included in your PR.

Can you please rebase to ensure this pr is only a single commit with just the version bumps.

Thanks!

@samuelbartels20
Copy link
Contributor Author

Hey @samuelbartels20 thanks for raising this. It looks like your starting branch was not completely clean / up to date as there are two commits showing and there are some unrelated changes included in your PR.

Can you please rebase to ensure this pr is only a single commit with just the version bumps.

Thanks!

@jmhbnz Thank you so much for the review. Please, I will work on the changes ASAP.

@samuelbartels20 samuelbartels20 deleted the go/1.23.3 branch November 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz requested changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelbartels20 @k8s-ci-robot @jmhbnz @spurin