Notification nouveaux JDD : répare matching avec mots-clefs #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineAugusti
commented
Jan 14, 2025
| @@ -257,8 +265,27 @@ defmodule Transport.Jobs.NewDatagouvDatasetsJob do | |||
| "velo" | |||
| iex> normalize("Châteauroux") | |||
| "chateauroux" | |||
| iex> normalize("J'adore manger") | |||
| "j'adore manger" | |||
There was a problem hiding this comment.
Précédemment on avait ça
iex> "J'adore manger" |> String.normalize(:nfd) |> String.replace(~r/[^A-z]/u, "") |> String.downcase()
"jadoremanger"ce n'était pas attendu, les espaces sont importants à converser pour le matching avec les mots-clefs
Comment on lines
224
to
234
| {words_with_spaces, words_without_spaces} = Enum.split_with(searches, &String.contains?(&1, " ")) | ||
| match_without_spaces = not (str | ||
| |> normalize() | ||
| |> String.split(~r/\s+/) | ||
| |> MapSet.new() | ||
| |> MapSet.disjoint?(MapSet.new(words_without_spaces)) | ||
| ) | ||
| match_with_spaces = str |> normalize() |> String.contains?(words_with_spaces) | ||
| match_without_spaces || match_with_spaces |
There was a problem hiding this comment.
C'est pas le plus clair, si vous avez une idée de refactor je prends 👌
| "libre-service", | ||
| "libre service", | ||
| "scooter" |
There was a problem hiding this comment.
Était en double précédemment, j'ai ajouté le pluriel aussi
AntoineAugusti
force-pushed
the
new_datagouv_datasets_job_full_words
branch
from
df66671 to
567edc4
Compare
AntoineAugusti
force-pushed
the
new_datagouv_datasets_job_full_words
branch
from
567edc4 to
c7444ea
Compare
ptitfred
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4411
Adapte
NewDatagouvDatasetsJoben charge d'identifier les JDDs pertinents à référencer sur le PAN. Le code précédent était trop laxiste : pour une catégorie "vélos" avec le mot clé "vélo" qui nous intéresse, on aurait dit qu'un JDD avec un tagdeveloppement-durableétait pertinent.J'adapte donc la méthode en charge de supprimer les accents (qui supprimait les espaces avant…) et la méthode de matching en fonction de mots-clefs. Un simple
String.contains?ne suffit pas.