Validateur NeTEx : timeout de 15 minutes #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le validateur d'enRoute peut tomber dans un état incohérent et le statut d'une validation rester en pending éternellement. Ce patch implémente un timeout de notre côté. Il est configuré arbitrairement à 15 minutes pour l'instant.
| "pending" -> | ||
| case {get_datetime(response, "created_at"), get_datetime(response, "updated_at")} do | ||
| {{:ok, created_at, _}, {:ok, updated_at, _}} -> | ||
| {:pending, DateTime.diff(updated_at, created_at)} |
There was a problem hiding this comment.
Faut updater le @callback parce que :pending a changé. Pas vu par Dialyzer ? 🤔
There was a problem hiding this comment.
Bon, semble pas… 😢 Faut un @spec en plus ? 🤔
There was a problem hiding this comment.
En effet dialyzer est pas défrisé ; décevant...
AntoineAugusti
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le validateur d'enRoute peut tomber dans un état incohérent et le statut d'une validation rester en pending éternellement. Ce patch implémente un timeout de notre côté. Il est configuré arbitrairement à 15 minutes pour l'instant.
Voir #4153.