Refactor Notes interface and update related logic to use 'path' inste…

…ad of 'file' #23
estruyf · Jan 5, 2025 · 5b4d197 · 5b4d197
1 parent a3e07e6
commit 5b4d197
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/models/Demos.ts b/src/models/Demos.ts
@@ -20,8 +20,8 @@ export interface Demo {
 }
 
 export interface Notes {
-  file: string;
-  show?: boolean;
+  path: string;
+  showOnTrigger?: boolean;
 }
 
 export interface Icons {

diff --git a/src/panels/DemoPanel.ts b/src/panels/DemoPanel.ts
@@ -97,7 +97,7 @@ export class DemoPanel {
           ctxValue = "demo-time.lastStep";
         }
 
-        const hasNotes = notesFolder && demo.notes?.file ? true : false;
+        const hasNotes = notesFolder && demo.notes?.path ? true : false;
         if (hasNotes) {
           ctxValue += " demo-time.hasNotes";
         }
@@ -129,7 +129,7 @@ export class DemoPanel {
           undefined,
           parseWinPath(path),
           idx,
-          demo.notes?.file
+          demo.notes?.path
         );
       });
 

diff --git a/src/services/NotesService.ts b/src/services/NotesService.ts
@@ -16,8 +16,8 @@ export class NotesService {
   }
 
   public static async showNotes(demo: Demo) {
-    if (demo.notes && demo.notes.file && demo.notes.show) {
-      NotesService.openNotes(demo.notes.file);
+    if (demo.notes && demo.notes.path && demo.notes.showOnTrigger) {
+      NotesService.openNotes(demo.notes.path);
     }
   }