-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to edition 2018, deps and docs #108
Conversation
@calvinbrown085 I would love a review on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estk Now that we are on 2018, can we get rid of some of the extern crate *
lines in lib.rs
?
https://github.com/estk/log4rs/blob/master/src/lib.rs#L170
For example:
extern crate arc_swap;
or
extern crate log;
If we aren't using any macros from the library I believe we can get rid of them, but I could be wrong there :)
@estk I think my only question was #108 (review) |
@calvinbrown085 thanks for the review! Removing the extern crate stuff is a little harder than I thought, but its in the works. Thanks again! |
@estk You're welcome! |
@estk Anything I can help out with here? |
@calvinbrown085 I'm slammed with the holidays coming up. I'm inclined to merge this as is and open an issue to remove the |
#113 addresses the extern crate stuff, not sure its ready to be shipped though |
@estk Yeah totally understandable! I can help with the extern crate stuff. I think this is ready to 🚢 |
Also, apologies if that came off as forceful! |
Closes #105
Closes #106