Merge pull request #70 from essentialkaos/develop

Version 0.19.1
essentialkaos · May 3, 2018 · bbe344e · bbe344e
2 parents 163d4e9 + 7621f17
commit bbe344e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/cli/cli.go b/cli/cli.go
@@ -52,7 +52,7 @@ import (
 // App info
 const (
 	APP  = "RBInstall"
-	VER  = "0.19.0"
+	VER  = "0.19.1"
 	DESC = "Utility for installing prebuilt ruby versions to rbenv"
 )
 
@@ -599,7 +599,7 @@ func installCommand(rubyVersion string) {
 
 	// //////////////////////////////////////////////////////////////////////////////// //
 
-	fmtc.Printf("Fetching {c}%s {s-}(%s){!}…\n", info.Name, fmtutil.PrettySize(info.Size))
+	fmtc.Printf("Fetching {c}%s {s-}(%s){!} from CDN…\n", info.Name, fmtutil.PrettySize(info.Size))
 
 	url := knf.GetS(STORAGE_URL) + "/" + info.Path + "/" + info.File
 	file, err := downloadFile(url, info.File)

diff --git a/cli/task.go b/cli/task.go
@@ -38,8 +38,14 @@ var (
 // Start start task
 func (t *Task) Start(args ...string) (string, error) {
 	t.start = time.Now()
+	t.spinnerActive = true
+	t.spinnerHiden = false
 
-	go t.showSpinner()
+	if options.GetB(OPT_NO_PROGRESS) {
+		t.spinnerHiden = true
+	} else {
+		go t.showSpinner()
+	}
 
 	result, err := t.Handler(args...)
 
@@ -48,15 +54,9 @@ func (t *Task) Start(args ...string) (string, error) {
 	return result, err
 }
 
-func (t *Task) showSpinner() {
-	if options.GetB(OPT_NO_PROGRESS) {
-		t.spinnerHiden = true
-		return
-	}
-
-	t.spinnerActive = true
-	t.spinnerHiden = false
+// ////////////////////////////////////////////////////////////////////////////////// //
 
+func (t *Task) showSpinner() {
 SPINNERLOOP:
 	for {
 		for i, frame := range spinnerFrames {

diff --git a/common/rbinstall.spec b/common/rbinstall.spec
@@ -44,7 +44,7 @@
 
 Summary:         Utility for installing prebuilt ruby to rbenv
 Name:            rbinstall
-Version:         0.19.0
+Version:         0.19.1
 Release:         0%{?dist}
 Group:           Applications/System
 License:         EKOL
@@ -143,6 +143,10 @@ rm -rf %{buildroot}
 ###############################################################################
 
 %changelog
+* Thu May 03 2018 Anton Novojilov <[email protected]> - 0.19.1-0
+- [cli] Possible fixed bug with spinner for fast tasks
+- [cli] Minor UI improvements
+
 * Thu Apr 26 2018 Anton Novojilov <[email protected]> - 0.19.0-0
 - [cli|gen] Added EOL info support (end-of-life)
 - [cli|gen|clone] Fixed bug with error output to stdout