Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow unsafely customise META_FIELDS #144

Closed
wants to merge 2 commits into from

Conversation

yidingww
Copy link

Prerequisites checklist

What is the purpose of this pull request?

Currently config array assumes name is the only meta field that should be treated as descriptive information when checking ignore and matching configs.

However, in certain scenarios, we should allow customization of the default META_FIELDS.

What changes did you make? (Give an overview)

Expose an UNSAFE_extraMetaFields, which will be combined with const META_FIELDS as the instance's this.metaFields, which will be used everywhere instead of const META_FIELDS.

Related Issues

N/A

Is there anything you'd like reviewers to focus on?

N/A

@yidingww yidingww changed the title feat: allow unsafely customise meta_fields feat: allow unsafely customise META_FIELDS Dec 30, 2024
@nzakas
Copy link
Member

nzakas commented Dec 30, 2024

I'm sorry, I can't tell what use case you're trying to solve. In any case, this isn't the way we design APIs. If you have a use case in mind, please open an issue and describe it so we can discuss.

@nzakas nzakas closed this Dec 30, 2024
@comp615
Copy link

comp615 commented Jan 2, 2025

@nzakas this probably should have included a reference to the upstream patch where the author is trying to update config-inspector so that it more closely mirrors the REAL logic of ESlint: eslint/config-inspector#115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants