-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve network configuration of catlets #280
Conversation
Fix tests
Improve update tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command fails:
PS C:\Users\Admin\Desktop> Get-VNetwork -ProjectName my
Id : 13719414-4062-4611-9556-ca008be5038a
Name : overlay
Project : my (77855dd0-42cc-404d-b4fd-36cc8c724276)
Environment : default
ProviderName : overlay
IpNetwork : 172.16.0.0/20
Id : 91ad10dd-42ae-40fe-a401-976cfedadc25
Name : default
Project : my (77855dd0-42cc-404d-b4fd-36cc8c724276)
Environment : default
ProviderName : default
IpNetwork : 10.0.0.0/20
Get-VNetwork : Value cannot be null.
Parameter name: ipNetwork
At line:1 char:1
+ Get-VNetwork -ProjectName my
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [Get-VNetwork], ArgumentNullException
+ FullyQualifiedErrorId : System.ArgumentNullException,Eryph.ComputeClient.Commands.Networks.GetVNetworksCommand
Project network:
version: 1.0
project: my
networks:
- name: default
address: 10.0.0.0/20
subnets:
- name: default
ip_pools:
- name: default
first_ip: 10.0.0.100
last_ip: 10.0.0.240
next_ip: 10.0.0.100
dns_servers:
- 9.9.9.9
- 8.8.8.8
mtu: 1400
- name: overlay
provider: overlay
address: 172.16.0.0/20
subnets:
- name: default
ip_pools:
- name: default
first_ip: 172.16.0.10
last_ip: 172.16.0.100
dns_servers:
- 9.9.9.9
- 8.8.8.8
mtu: 1400
- name: flat
provider: lan
stops failing if I add
address: 192.168.112.0/24 (my test flat vlan) in project network.
added #281 for the project routing issue |
Cleanup tests
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a detection of eryph_default net NAT and removal when syncing networks (autosync mode).
My test setup was wrong, this considered already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I found was caused by #281
This PR improves the network configuration and fixes multiple issues. The improvements include:
Closes #269.