Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network configuration of catlets #280

Merged
merged 30 commits into from
Dec 2, 2024

Conversation

ChristopherMann
Copy link
Collaborator

@ChristopherMann ChristopherMann commented Nov 14, 2024

This PR improves the network configuration and fixes multiple issues. The improvements include:

  • Proper support for flat networks
  • Proper support for multiple provider subnets and IP pools (nat-overlay only supports a single subnet)
  • Proper support for switching between virtual networks and network providers
  • Improve configuration of host NetNat

Closes #269.

@ChristopherMann ChristopherMann marked this pull request as ready for review November 15, 2024 16:22
Copy link
Member

@fw2568 fw2568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command fails:

PS C:\Users\Admin\Desktop> Get-VNetwork -ProjectName my


Id           : 13719414-4062-4611-9556-ca008be5038a
Name         : overlay
Project      : my (77855dd0-42cc-404d-b4fd-36cc8c724276)
Environment  : default
ProviderName : overlay
IpNetwork    : 172.16.0.0/20

Id           : 91ad10dd-42ae-40fe-a401-976cfedadc25
Name         : default
Project      : my (77855dd0-42cc-404d-b4fd-36cc8c724276)
Environment  : default
ProviderName : default
IpNetwork    : 10.0.0.0/20

Get-VNetwork : Value cannot be null.
Parameter name: ipNetwork
At line:1 char:1
+ Get-VNetwork -ProjectName my
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-VNetwork], ArgumentNullException
    + FullyQualifiedErrorId : System.ArgumentNullException,Eryph.ComputeClient.Commands.Networks.GetVNetworksCommand

Project network:

version: 1.0
project: my
networks:
- name: default
  address: 10.0.0.0/20
  subnets:
  - name: default
    ip_pools:
    - name: default
      first_ip: 10.0.0.100
      last_ip: 10.0.0.240
      next_ip: 10.0.0.100
    dns_servers:
    - 9.9.9.9
    - 8.8.8.8
    mtu: 1400

- name: overlay
  provider: overlay
  address: 172.16.0.0/20
  subnets:
  - name: default
    ip_pools:
    - name: default
      first_ip: 172.16.0.10
      last_ip: 172.16.0.100
    dns_servers:
    - 9.9.9.9
    - 8.8.8.8
    mtu: 1400


- name: flat
  provider: lan

stops failing if I add

address: 192.168.112.0/24 (my test flat vlan) in project network.

@fw2568
Copy link
Member

fw2568 commented Nov 20, 2024

added #281 for the project routing issue

fw2568
fw2568 previously requested changes Dec 2, 2024
Copy link
Member

@fw2568 fw2568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a detection of eryph_default net NAT and removal when syncing networks (autosync mode).
My test setup was wrong, this considered already.

@fw2568 fw2568 dismissed their stale review December 2, 2024 09:06

test error

Copy link
Member

@fw2568 fw2568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I found was caused by #281

@ChristopherMann ChristopherMann merged commit 164f7e3 into main Dec 2, 2024
9 checks passed
@ChristopherMann ChristopherMann deleted the pull/flat-network-issues branch December 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flat network support is broken
2 participants