Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zone should be explicitly set for timestamp related tests #89

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

chiroptical
Copy link
Contributor

@chiroptical chiroptical commented Sep 10, 2024

If you change this to America/New_York the test will fail. My machine by default was set to that.

> rebar3 ct --suite=test/pgo_datetime_SUITE.erl
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling pgo
===> Running Common Test suites...
%%% pgo_datetime_SUITE: ......
All 6 tests passed.

src/pgo.app.src Outdated Show resolved Hide resolved
@chiroptical
Copy link
Contributor Author

chiroptical commented Oct 30, 2024

@tsloughter I can't reproduce that error anymore. Unsure exactly.

Next things on my list,

  • Get types checking again
  • Make the test environment less dependent on the docker-compose.yaml file

(note: this are completely separate from this PR but I had them on my mind for whatever reason)

@tsloughter
Copy link
Collaborator

Sounds good 👍

@tsloughter tsloughter merged commit 53fea8d into erleans:main Oct 31, 2024
2 checks passed
@chiroptical chiroptical deleted the chiroptical/issue-88 branch November 14, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants