ssl: Termination needs to be best effort, can fail for DTLS #9337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngelaAndin
added
team:PS
CT Test Results 1 files 11 suites 4m 6s ⏱️ Results for commit 1441260. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
dgud
reviewed
Jan 24, 2025
lib/ssl/src/ssl_gen_statem.erl
Outdated
| } = State0) -> | ||
| } = State0) -> |
dgud
previously approved these changes
Jan 24, 2025
Always sending alert when terminating is according to TLS protocol but as DTLS is by default over UDP there can be conercases that we do not want to result in a crassh but we can do nothing about.
IngelaAndin
force-pushed
the
ingela/ssl/termination/OTP-19411
branch
from
2454325 to
1441260
Compare
dgud
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always sending alert when terminating is according to TLS protocol but as DTLS is by default over UDP there can be conercases that we do not want to result in a crassh but we can do nothing about.