stdlib: Fix zip:unzip on read-only directory with content #9335
+51
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
added
team:VM
garazdawi
changed the title
garazdawi
force-pushed
the
lukas/stdlib/zip-permission-directories/OTP-19447
branch
from
df24a9d to
8a73aad
Compare
CT Test Results 2 files 95 suites 1h 6m 27s ⏱️ Results for commit 5e00369. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
You could use the test zip I included in the issue in a integration test. Its just a readme file with the text hello world in a read only folder. |
The permissions were set on extrected directories before the files within were extracted, making it impossible to create the files within. This commit delays all directory permissions to after all files/directories have been created so that they can all be set. Closed erlang#9332
garazdawi
force-pushed
the
lukas/stdlib/zip-permission-directories/OTP-19447
branch
from
5e00369 to
d384e2a
Compare
|
I tested locally with your file and the additions to the test suite trigger the same fault, so I think we are good without that file. Fix is merged for release in Erlang/OTP 27.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions were set on extrected directories before the files within were extracted, making it impossible to create the files within. This commit delays all directory permissions to after all files/directories have been created so that they can all be set.
Closed #9332