Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .elp.toml file #9328

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

robertoaloi
Copy link
Contributor

The .elp.toml file, documented here, allows the ELP language server to correctly discover the project. This is equivalent to the erlang_ls.config file which is already present (for the Erlang LS language server).

Copy link
Contributor

github-actions bot commented Jan 22, 2025

CT Test Results

  1 files   11 suites   5m 3s ⏱️
 93 tests  91 ✅ 2 💤 0 ❌
109 runs  107 ✅ 2 💤 0 ❌

Results for commit 1ec3208.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@robertoaloi
Copy link
Contributor Author

I'm currently trying to add a few configuration options to ELP that can take care of a few details with apps such as wx and common_test, that require special tweaking. So, please hold on this one.

@williamthome
Copy link
Contributor

FYI, @garazdawi have added it here a1192b3 in #9316.

@garazdawi
Copy link
Contributor

I've removed mine in favor of this.

@robertoaloi
Copy link
Contributor Author

@garazdawi I copied the header from your version in re a1192b3, but the copyright checker still complains. What should that contain?

.elp.toml Outdated
"lib/*",
{"name" = "erts", "dir" = "erts/preloaded", "src_dirs" = ["src"]},
{"name" = "wx", "dir" = "lib/wx", "src_dirs" = ["src", "gen"]},
{"name" = "inets", "dir" = "lib/inets", "src_dirs" = ["src/http_client", "src/http_server", "src/http_lib", "inets_app"]},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "src/inets_app", I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,15 @@
# SPDX-License-Identifier: Apache-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# SPDX-License-Identifier: Apache-2.0
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: 2025 Ericsson and the Erlang/OTP contributors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting used to writing these things so forgot the copyright in my commit.

@rickard-green rickard-green added the team:PS Assigned to OTP team PS label Jan 27, 2025
@dgud dgud changed the base branch from master to maint January 28, 2025 08:12
@dgud dgud changed the base branch from maint to master January 28, 2025 08:12
@dgud
Copy link
Contributor

dgud commented Jan 28, 2025

And rebase on top of maint so we can get it in for 27 as well.

@IngelaAndin IngelaAndin added the waiting waiting for changes/input from author label Jan 28, 2025
@robertoaloi
Copy link
Contributor Author

Rebased on top of maint, fixed copyright headers and missing src/.

@garazdawi garazdawi merged commit a64361e into erlang:master Jan 29, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS waiting waiting for changes/input from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants