Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: fixes socket.erl type spec #9295

Conversation

kikofernandez
Copy link
Contributor

The type specs for socker.erl were improved in PR-8986, but they introduced a bug by omitting one of the overloaded specs. this commit fixes that.

closes #9180

@kikofernandez kikofernandez requested a review from bmk January 14, 2025 09:27
@kikofernandez kikofernandez self-assigned this Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

CT Test Results

    2 files     70 suites   1h 5m 8s ⏱️
1 556 tests 1 308 ✅ 243 💤 5 ❌
1 774 runs  1 493 ✅ 276 💤 5 ❌

For more details on these failures, see this check.

Results for commit 3503e50.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

bmk
bmk previously approved these changes Jan 14, 2025
@garazdawi
Copy link
Contributor

Shouldn't the tests in dialyzer test dialyzer? These tests seem to test socket? I get the need for these types of tests, but I don't think the place to have them is in dialyzer. Instead they should be in kernel in a suite designed for testing specs.

@kikofernandez
Copy link
Contributor Author

Yes, I think that sounds right. I will see what I can do

@kikofernandez kikofernandez force-pushed the kiko/kernel/fix-socket-typespec/OTP-19429 branch from b8599b0 to f7b9c07 Compare January 16, 2025 09:55
@kikofernandez kikofernandez requested a review from bmk January 16, 2025 09:57
@kikofernandez
Copy link
Contributor Author

For now, we will have to go without the test.
I tried running Dialyzer in some test suites and there are way too many errors to use test suites as the type tests.

This is something we (OTP) will have to look into

@kikofernandez kikofernandez added the testing currently being tested, tag is used by OTP internal CI label Jan 20, 2025
the type specs for socker.erl were improved in PR-8986, but they
introduced a bug by omitting one of the overloaded specs.
@kikofernandez kikofernandez force-pushed the kiko/kernel/fix-socket-typespec/OTP-19429 branch from f7b9c07 to 3503e50 Compare January 20, 2025 14:35
@kikofernandez kikofernandez merged commit 2e5473f into erlang:maint Jan 21, 2025
22 of 24 checks passed
@kikofernandez kikofernandez deleted the kiko/kernel/fix-socket-typespec/OTP-19429 branch January 21, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants