-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel: fixes socket.erl type spec #9295
kernel: fixes socket.erl type spec #9295
Conversation
CT Test Results 2 files 70 suites 1h 5m 8s ⏱️ For more details on these failures, see this check. Results for commit 3503e50. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Shouldn't the tests in dialyzer test dialyzer? These tests seem to test socket? I get the need for these types of tests, but I don't think the place to have them is in dialyzer. Instead they should be in kernel in a suite designed for testing specs. |
Yes, I think that sounds right. I will see what I can do |
b8599b0
to
f7b9c07
Compare
For now, we will have to go without the test. This is something we (OTP) will have to look into |
the type specs for socker.erl were improved in PR-8986, but they introduced a bug by omitting one of the overloaded specs.
f7b9c07
to
3503e50
Compare
The type specs for
socker.erl
were improved in PR-8986, but they introduced a bug by omitting one of the overloaded specs. this commit fixes that.closes #9180