-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: Break out aead_one_time to 2 functions #9289
Conversation
CT Test Results 2 files 14 suites 5m 36s ⏱️ Results for commit 05efc8b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you change ct- printing to io:format in test suite? Is it not good to use ct functions for test suite io?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Some minor comments.
To allow ssl send fewer arguments to and re-use the initialization. While at it change the crypto:crypto_one_time_aead[_init]/4 to automatically, append or, use the tag at the end data.
e371708
to
05efc8b
Compare
To allow ssl send fewer arguments to and re-use the initialization.
While at it change the crypto:crypto_one_time_aead[_init]/4 to automatically, append or, use the tag at the end data.