Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Break out aead_one_time to 2 functions #9289

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dgud
Copy link
Contributor

@dgud dgud commented Jan 13, 2025

To allow ssl send fewer arguments to and re-use the initialization.

While at it change the crypto:crypto_one_time_aead[_init]/4 to automatically, append or, use the tag at the end data.

@dgud dgud added the team:PS Assigned to OTP team PS label Jan 13, 2025
@dgud dgud self-assigned this Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

CT Test Results

  2 files   14 suites   5m 36s ⏱️
186 tests 172 ✅  14 💤 0 ❌
459 runs  329 ✅ 130 💤 0 ❌

Results for commit 05efc8b.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Jan 13, 2025
@dgud dgud requested a review from sverker January 13, 2025 16:08
IngelaAndin
IngelaAndin previously approved these changes Jan 14, 2025
Copy link
Contributor

@IngelaAndin IngelaAndin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you change ct- printing to io:format in test suite? Is it not good to use ct functions for test suite io?

sverker
sverker previously approved these changes Jan 14, 2025
Copy link
Contributor

@sverker sverker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Some minor comments.

lib/crypto/c_src/aead.c Outdated Show resolved Hide resolved
lib/crypto/c_src/aead.c Outdated Show resolved Hide resolved
lib/crypto/c_src/aead.h Outdated Show resolved Hide resolved
lib/crypto/src/crypto.erl Outdated Show resolved Hide resolved
@dgud dgud dismissed stale reviews from sverker and IngelaAndin via e371708 January 14, 2025 14:35
To allow ssl send fewer arguments to and re-use the initialization.

While at it change the crypto:crypto_one_time_aead[_init]/4 to
automatically, append or, use the tag at the end data.
@dgud dgud force-pushed the dgud/crypto/ssl-opts/OTP-19426 branch from e371708 to 05efc8b Compare January 14, 2025 15:57
@dgud dgud requested a review from sverker January 15, 2025 10:02
@dgud dgud merged commit 02c007b into erlang:master Jan 15, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants