Ets and Dets code should not be printing to stdout

[richcarl]

Some quite old code in Ets and Dets would print messages to stdout when repairing tables or when fun2ms failed.

[github-actions]

CT Test Results

    2 files     96 suites   1h 7m 33s ⏱️
2 173 tests 2 125 ✅ 48 💤 0 ❌
2 536 runs  2 486 ✅ 50 💤 0 ❌

Results for commit 3bad824.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[IngelaAndin]

I think you should use logger instead of calling legacy error_logger functions.

[richcarl]

I think you should use logger instead of calling legacy error_logger functions.

That would introduce a mix of old error_logger calls and new logger calls. I think it is better to follow the existing code style and then replace all of the calls in a separate update.

[IngelaAndin]

@richcarl well ok we will accept that, as at least it is an improvement over using io:format. However the PS-team does not feel
that it is granted to remove the debug printouts that have no affect unless you uncomment some lines and recompile. Although this is not a coding style that we prefer, this code is old and may still have a educational purpose for someone that needs to maintain it. And we would rather keep it for now and maybe it will be refactored sometime in the future.

[richcarl]

Fair enough, I dropped the macro removal. IMO though, the only place for that sort of code is in the version control history.