Alias analysis cleanups #8620
Merged
Alias analysis cleanups #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With c3859f6 ("Make sets default to maps-based implementation") there is no longer a need to explicitly ask for version 2 sets.
With c3859f6 ("Make sets default to maps-based implementation") there is no longer a need to explicitly ask for version 2 sets.
An `update_record` instruction will always have an `arg_types` annotation as it will either be preceded by a guard test which allows the type pass to deduce the types, or else, when the guard is missing, the types are known, ie there is an annotation present.
Remove an explicit error case in the alias analysis pass which currently is the only uncovered line in the coverage report for the pass. During development it was helpful to have a clear-text exit instead of a match failure when an unknown instruction was encountered, but now as the code has matured, it is only noise in the coverage report. Therefore remove it, as, if a new ssa instruction is added, it will be obvious from the error message what the problem is.
CT Test Results 2 files 324 suites 10m 45s ⏱️ Results for commit 7679273. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
bjorng
added
team:VM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanups which update the alias analysis pass modules. The changes removes the explicit version argument to
sets:new()and friends as the maps-based implementation is now the default. They also remove dead code, which brings up the test coverage to 100% for thebeam_ssa_aliasandbeam_ssa_ss modules. No functional changes.