Deprecate crypto:start/stop() #8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 15 files 681 suites 5h 3m 18s ⏱️ For more details on these failures, see this check. Results for commit 15f7d8e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
approved these changes
Jun 18, 2024
sverker
force-pushed
the
sverker/crypto/deprecate-start-stop
branch
2 times, most recently
from
c6d175b to
cc46f7a
Compare
Use application:start/stop(crypto) instead.
According to OpenSSL 3 documentation the function EVP_default_properties_enable_fips() used by enable_fips_mode "...are not thread safe. They are intended to be called only during the initialisation phase of a libctx."
sverker
force-pushed
the
sverker/crypto/deprecate-start-stop
branch
from
15f7d8e to
4667d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating
crypto:start()as it does not work for FIPS mode (see #8590).crypto:stop()also deprecated just for symmetry.All calls to
crypto:start/stop()changed toapplication:start/stop(crypto).Also deprecate
crypto:enable_fips_mode/1as it's not thread safe and should not be used in production.