Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in 'crl_check' documentation #8563

Closed
wants to merge 50 commits into from

Conversation

rlipscombe
Copy link
Contributor

No description provided.

josevalim and others added 30 commits April 28, 2024 13:05
Previously, we were wrapping the combiner function
without an actual need. We also use this opportunity
to remove an unused argument.
link is broken
Co-authored-by: Lukas Larsson <[email protected]>
* maint:
  Correct typos
Optimize maps:merge_with/3 for maps of equal size
* maint:
  Correct typo in docs: invalid_sequence -> unexpected_sequence
* maint:
  Remove OAM Principles chapter from the documentation
Using the map syntax instead of `maps:put/3` is slightly more
efficient in itself, but also reduces register shuffling and can open
up for combining multiple adjacent map update operations into a single
update operation.
u3s and others added 20 commits June 4, 2024 09:26
* maint:
  JIT: Fix unsafe in-place update during disabled GC
  JIT: Fix unsafe destructive record update
Remove dead macro ERTS_FOREACH_OP_RUNQ
…ps-puts-3/OTP-19115

Inline safe calls to maps:put/3
Make sets default to maps-based implementation

OTP-19127
* maint:
  [erts] Fix DOWN signal from port
All locks within a level are unordered and not supposed to be seized
at the same time. The lock checker will complain if that happens.

The main purpose is to make it easier to reason and understand the lock order
when need to change it arises.
Simplify dot files

by removing implicit indirect dependencies

A -> B -> C

do not show arrow A -> C
even if the lc_graph file has it as a direct dependency
as C has been locked after A without B being involved.
Using pipe will lose the exit status of gcc

gcc ... | sed ... > $@

Instead run sed separately

gcc ... > [email protected]
sed [email protected] > $@

We use a temporary file as sed option -i is not portable.
* maint:
  Fix disk_log bug/typo
  Fix json encode_map_checked encode_key_value_list_checked
Copy link
Contributor

github-actions bot commented Jun 11, 2024

CT Test Results

    2 files     67 suites   48m 52s ⏱️
  789 tests   745 ✅  44 💤 0 ❌
3 756 runs  2 962 ✅ 794 💤 0 ❌

Results for commit 8b01a39.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kikofernandez
Copy link
Contributor

Please, could you rebase this on top of maint instead?
Thanks!

@kikofernandez kikofernandez self-assigned this Jun 17, 2024
@rlipscombe rlipscombe changed the base branch from master to maint June 17, 2024 07:42
@rlipscombe
Copy link
Contributor Author

I cannot figure out how to rebase a single commit. Gonna re-open it.

@rlipscombe rlipscombe closed this Jun 17, 2024
@rlipscombe rlipscombe deleted the rl/fix-crl-check-typo branch June 17, 2024 07:44
@rlipscombe
Copy link
Contributor Author

See #8587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.