Fix invalid crossref warning for Mod:module_info() (#1471)

erlang-ls · Jan 8, 2024 · d351643 · d351643
1 parent 3e54aae
commit d351643
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/apps/els_lsp/priv/code_navigation/src/diagnostics_xref_pseudo.erl b/apps/els_lsp/priv/code_navigation/src/diagnostics_xref_pseudo.erl
@@ -33,4 +33,6 @@ main() ->
 
   % At lease one failure so we know the diagnostic is running
   unknown_module:nonexistent(),
+  Mod:module_info(),
+  Mod:module_info(module),
   ok.
diff --git a/apps/els_lsp/src/els_crossref_diagnostics.erl b/apps/els_lsp/src/els_crossref_diagnostics.erl
@@ -95,31 +95,31 @@ has_definition(
 has_definition(
     #{
         kind := application,
-        id := {Module, module_info, Arity}
+        data := #{mod_is_variable := true}
     },
     _
-) when Arity =:= 0; Arity =:= 1 ->
-    {ok, []} =/= els_dt_document_index:lookup(Module);
+) ->
+    true;
 has_definition(
     #{
         kind := application,
-        id := {record_info, 2}
+        id := {Module, module_info, Arity}
     },
     _
-) ->
-    true;
+) when Arity =:= 0; Arity =:= 1 ->
+    {ok, []} =/= els_dt_document_index:lookup(Module);
 has_definition(
     #{
         kind := application,
-        id := {behaviour_info, 1}
+        id := {record_info, 2}
     },
     _
 ) ->
     true;
 has_definition(
     #{
         kind := application,
-        data := #{mod_is_variable := true}
+        id := {behaviour_info, 1}
     },
     _
 ) ->