Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker]: Optimized Dockerfile and updated .dockerignore #1544

Merged
merged 5 commits into from
Nov 26, 2023

Conversation

ongsuwannoo
Copy link
Contributor

This pull request includes optimizations for our Dockerfile.

Changes include combining RUN commands to reduce the number of layers in the image, using --no-install-recommends with apt-get install to avoid installing unnecessary packages, cleaning up the apt cache after installing packages to reduce the image size, and using a .dockerignore file to exclude unnecessary files and directories from the build context. These changes aim to improve the build speed and reduce the size of the final Docker image.

Copy link
Contributor Author

@ongsuwannoo ongsuwannoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Cancel doing this.

In this commit, I've updated the prod script in package.json. The updated script now ensures that the TypeScript code is compiled before the application is started in production. This change will help us avoid potential runtime errors due to differences between TypeScript and JavaScript.

@eritislami eritislami merged commit b9d31d7 into eritislami:master Nov 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants