Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy lints since Rust 1.83 #411

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Fix clippy lints since Rust 1.83 #411

merged 6 commits into from
Dec 12, 2024

Conversation

MarijnS95
Copy link
Contributor

  • Recommit Rust 1.83 compile-fail output
  • Automatically fix new clippy lints on Rust 1.83
  • Drop stale compiletest code
  • Manually fix remaining clippy lints

@MarijnS95 MarijnS95 mentioned this pull request Dec 12, 2024
Merged
@MarijnS95
Copy link
Contributor Author

MarijnS95 commented Dec 12, 2024 •
edited
Loading

It looks like the new tests on MacOS cut off the last line(s) of the expected error...

@MarijnS95
Copy link
Contributor Author

MarijnS95 commented Dec 12, 2024 •
edited
Loading

Looks like the rest of the runners do too... They print the filename of where note: required by a bound in `spawn` is going to be rendered, then skip the actual contents that show what spawn is going to be.

Could be an actions-rs bug though.

@MarijnS95
CI HACK: Truncate compile-fail stderr to match broken CI runs
9aafd84 
https://github.com/erickt/rust-zmq/actions/runs/12294855109/job/34310502917
@MarijnS95
CI: Replace deprecated/unmaintained actions-rs with simple run: s…
6142a2c 
…teps

The `actions-rs` containers haven't been maintained and updated for
years and don't need to: GitHub's actions environment already comes
fully loaded with a complete stable Rust installation with the standard
tools (clippy, rustfmt, rustdoc).  Simple `run:` commands relate
directly to what a developer can type in locally to "reproduce" the
CI environment while they might be following up on CI failures, and no
longer spam ancient Node 12 deprecation warnings.
@Jasper-Bekkers Jasper-Bekkers merged commit af63e12 into erickt:master Dec 12, 2024
9 checks passed
@MarijnS95 MarijnS95 deleted the clippy branch December 12, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasper-Bekkers Jasper-Bekkers Jasper-Bekkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarijnS95 @Jasper-Bekkers