Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CodeQL scan for GitHub Actions #1821

Merged
merged 7 commits into from
Jan 19, 2025
Merged

Conversation

ericcornelissen
Copy link
Owner

@ericcornelissen ericcornelissen commented Dec 17, 2024

Relates to #134, #1114, #1751

Summary

Update the CI configuration to run CodeQL on GitHub Actions in addition to JavaScript. This uses a matrix as suggested in the description of the "languages" input for the github/codeql-action/init action.

Based on https://github.blog/changelog/2024-12-17-find-and-fix-actions-workflows-vulnerabilities-with-codeql-public-preview/

Update the CI configuration to run CodeQL on GitHub Actions in addition
to JavaScript. This uses a matrix as suggested in the description of the
"languages" input for the `github/codeql-action/init` action.
@ericcornelissen ericcornelissen added ci/cd Relates to ci/cd security Relates to security labels Dec 17, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

with:
config-file: ./.github/codeql.yml
languages: javascript
# config-file: ./.github/codeql.yml
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job currently fails if this line is enabled because the configuration is not valid if matrix.what == 'actions', but we want the configuration for matrix.what == 'javascript'...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this is this line:

- uses: security-extended

which it complained about here.

This has been reported at github/codeql-action#2658

@ericcornelissen

This comment was marked as resolved.

@ericcornelissen ericcornelissen added the pending This cannot be worked on yet label Dec 19, 2024
@ericcornelissen ericcornelissen marked this pull request as draft December 19, 2024 16:05
@ericcornelissen

This comment was marked as outdated.

@ericcornelissen ericcornelissen marked this pull request as ready for review January 19, 2025 10:09
@ericcornelissen ericcornelissen removed the pending This cannot be worked on yet label Jan 19, 2025
@ericcornelissen ericcornelissen merged commit 644b07f into main Jan 19, 2025
34 checks passed
@ericcornelissen ericcornelissen deleted the try-codeql-actions branch January 19, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Relates to ci/cd security Relates to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant