Fix value prop and make setProps optional in Select component (#105)

equinor · Mar 28, 2021 · dd6dd2f · dd6dd2f
1 parent 9d08a49
commit dd6dd2f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [UNRELEASED] - YYYY-MM-DD
 ### Fixed
+- [#105](https://github.com/equinor/webviz-core-components/pull/105) - Fixed bug when updating Select values from a Dash callback.
+
+## [0.3.0] - 2021-03-26
+### Fixed
 - [#99](https://github.com/equinor/webviz-core-components/pull/99) - Fixed bug which prevented using the download button in `WebvizPluginPlaceholder` and started to download when component was mounting. 
 
 ### Added

diff --git a/src/lib/components/Select/Select.tsx b/src/lib/components/Select/Select.tsx
@@ -31,7 +31,7 @@ const Select = (props: InferProps<typeof Select.propTypes>): JSX.Element => {
             style={parent_style}
         >
             <select
-                defaultValue={value}
+                value={value}
                 multiple={multi}
                 size={size}
                 onChange={(e) => handleChange(e)}
@@ -129,7 +129,7 @@ Select.propTypes = {
     /**
      * Dash-assigned callback that gets fired when the input changes
      */
-    setProps: PropTypes.func.isRequired,
+    setProps: PropTypes.func,
     /**
      * Used to allow user interactions in this component to be persisted when
      * the component - or the page - is refreshed. If `persisted` is truthy and