Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new function phase.getComponentName #1236

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner January 6, 2025 13:35
@asmfstatoil asmfstatoil marked this pull request as draft January 6, 2025 14:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 32.95455% with 59 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (2b1a76c) to head (f12d319).

Files with missing lines Patch % Lines
...ceproperties/surfacetension/LGTSurfaceTension.java 0.00% 7 Missing ⚠️
...eqsim/thermo/characterization/WaxCharacterise.java 0.00% 4 Missing and 2 partials ⚠️
...perties/surfacetension/GTSurfaceTensionSimple.java 0.00% 5 Missing ⚠️
.../neqsim/standards/gasquality/Standard_ISO6578.java 60.00% 0 Missing and 4 partials ⚠️
.../java/neqsim/fluidmechanics/flownode/FlowNode.java 0.00% 3 Missing ⚠️
...idboundary/heatmasstransfercalc/FluidBoundary.java 0.00% 3 Missing ⚠️
.../neqsim/standards/gasquality/Standard_ISO6976.java 25.00% 3 Missing ⚠️
...actions/chemicalreaction/ChemicalReactionList.java 0.00% 2 Missing ⚠️
...neqsim/process/equipment/mixer/StaticNeqMixer.java 0.00% 2 Missing ⚠️
...qsim/process/equipment/mixer/StaticPhaseMixer.java 0.00% 2 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1236      +/-   ##
============================================
- Coverage     41.13%   41.13%   -0.01%     
- Complexity     6030     6031       +1     
============================================
  Files           722      723       +1     
  Lines         68334    68326       -8     
  Branches       8162     8162              
============================================
- Hits          28112    28108       -4     
+ Misses        38541    38537       -4     
  Partials       1681     1681              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update👍, guess it does not reduce speed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants