-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove task wise mode #699
Conversation
|
c01665c
to
daff8a8
Compare
daff8a8
to
8845b33
Compare
@@ -71,7 +61,7 @@ def initiate_task(self, task: Task) -> None: | |||
of the task until the number of allowed retries is exceeded before the task | |||
will be marked as failed and the mission cancelled | |||
NotImplementedError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few lines above this function still says "RobotInfeasibleTaskException" which I believe is no longer possible? Also you can delete this exception from robot_exception.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still a reasonable exception as we want to keep initiate_task for scheduling retrun to home from isar directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we want to initiate it as a task and not as a mission?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue so, yes
It might be easier to merge this PR first: #689 since it isolates all the task-wise code into specific transitions. Instead of deleting specific lines in various states, all we would need to do is delete the relevant transitions (and remove the Task option in starting missions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As this change entails less change in isar, we will take this in first and continue with it afterwards |
Ready for review checklist: