Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Access management #877

Merged
merged 49 commits into from
Dec 10, 2024
Merged

feat: Access management #877

merged 49 commits into from
Dec 10, 2024

Conversation

kjetilhau
Copy link
Member

@kjetilhau kjetilhau commented Nov 27, 2024

Description

This adds support for managing access to Portals through "Portal Admins".
Portal admins can be added and removed only by global administrators.
The Portal admin will have full access to manage the Portal after being assigned. There are two exceptions that will be unauthorized: Creating new portals and deleting portals

Breaking changes:

  • Creating portals will now require at least one administrator

  • Updating portals will now require at least one administrator

  • PR title and description are to the point and understandable

  • I have performed a self-review of my own code'

Please select version type the purposed change:

  • major
  • minor
  • patch
  • none

External Relations

  • database migration

Changeset

  • Portal Administrators can now be assigned to Portals
  • These will be able to manage the respective portal, updating content, apps and contexts

@kjetilhau kjetilhau self-assigned this Nov 27, 2024
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 342ac87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fusion-project-portal Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjetilhau kjetilhau linked an issue Nov 27, 2024 that may be closed by this pull request
@kjetilhau kjetilhau requested a review from Noggling December 5, 2024 13:18
@kjetilhau kjetilhau marked this pull request as ready for review December 5, 2024 13:22
@kjetilhau kjetilhau requested a review from a team as a code owner December 5, 2024 13:22

builder.HasKey(x => x.Id);

//builder.HasOne(aa => aa.Account)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skal dette bort?

.NotEmpty()
.WithMessage("Must specify at least one admin");

//RuleFor(x => x.Admins).BeValidAccounts(accountService);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove????

@@ -1,9 +1,16 @@
import { defineAppConfig } from '@equinor/fusion-framework-cli';

const feature = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix!

@kjetilhau kjetilhau merged commit 6953d9a into main Dec 10, 2024
7 checks passed
@kjetilhau kjetilhau deleted the feature/access-management branch December 10, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Portal: Portal Admin Access Management
2 participants