Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove start pose from isar missions #2011

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Feb 6, 2025

Will break if a isar-"robot" package has "localize" in capability list. Depends on this: equinor/isar-robot#200

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

Copy link

github-actions bot commented Feb 6, 2025

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Eddasol Eddasol force-pushed the remove-localize branch 2 times, most recently from 085ef9f to 39ac7d4 Compare February 6, 2025 11:26
@Eddasol Eddasol changed the title Remove localize Remove start pose from isar missions Feb 6, 2025
@Eddasol Eddasol self-assigned this Feb 6, 2025
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol merged commit 32f09d2 into equinor:main Feb 7, 2025
13 checks passed
@Eddasol Eddasol deleted the remove-localize branch February 7, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants