Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dock/undock from isar missions #2010

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Remove dock/undock from isar missions #2010

merged 3 commits into from
Feb 6, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Feb 5, 2025 •
edited
Loading

Related to equinor/isar#708

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Feb 5, 2025
@Eddasol Eddasol self-assigned this Feb 5, 2025
@Eddasol
Copy link
Contributor Author

Eddasol commented Feb 6, 2025

/UpdateDatabase

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit a25eec9 into equinor:main Feb 6, 2025
14 checks passed
@Eddasol Eddasol deleted the remove-dock branch February 6, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsundvoll tsundvoll tsundvoll approved these changes

Assignees

@Eddasol Eddasol

Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @tsundvoll