Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add placeholders to inspection report #1998

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Add placeholders to inspection report #1998

merged 5 commits into from
Feb 3, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 31, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol marked this pull request as draft January 31, 2025 09:47
@Eddasol Eddasol force-pushed the inspection-placeholder2 branch 2 times, most recently from fb77eb7 to 7608eaf Compare January 31, 2025 13:48
@Eddasol Eddasol linked an issue Jan 31, 2025 that may be closed by this pull request
Improve inspections view #1980
Closed
5 tasks
@Eddasol Eddasol marked this pull request as ready for review January 31, 2025 13:50
@Eddasol Eddasol force-pushed the inspection-placeholder2 branch 2 times, most recently from fbd6f41 to 30c0ab6 Compare January 31, 2025 13:53
@Eddasol Eddasol linked an issue Jan 31, 2025 that may be closed by this pull request
The inspections view should not appear with empty pictures if the inspections are not available yet (see picture below) #2001
Closed
@Eddasol Eddasol removed a link to an issue Jan 31, 2025
Improve inspections view #1980
Closed
5 tasks
@Eddasol Eddasol requested a review from mrica-equinor January 31, 2025 13:59
@Eddasol Eddasol self-assigned this Jan 31, 2025
@Eddasol Eddasol added feature New feature or request frontend Frontend related functionality labels Jan 31, 2025
@Eddasol Eddasol force-pushed the inspection-placeholder2 branch 5 times, most recently from 6e94cb5 to 461311f Compare February 3, 2025 11:56
mrica-equinor
mrica-equinor approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Eddasol Eddasol force-pushed the inspection-placeholder2 branch from 461311f to b285f57 Compare February 3, 2025 12:44
@Eddasol Eddasol merged commit d9c4e12 into equinor:main Feb 3, 2025
12 checks passed
@Eddasol Eddasol deleted the inspection-placeholder2 branch February 3, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrica-equinor mrica-equinor mrica-equinor approved these changes

Assignees

@Eddasol Eddasol

Labels
feature New feature or request frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
2 participants
@Eddasol @mrica-equinor