Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for running tests towards a postgreSQL database #1966

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Add support for running tests towards a postgreSQL database #1966

merged 5 commits into from
Jan 22, 2025

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Jan 17, 2025

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@aeshub aeshub added feature New feature or request backend Backend related functionality labels Jan 17, 2025
@aeshub aeshub self-assigned this Jan 17, 2025
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Jan 17, 2025
@aeshub aeshub marked this pull request as draft January 20, 2025 12:30
@aeshub
Copy link
Contributor Author

aeshub commented Jan 20, 2025

Awaiting merge of #1965 before review is required

@aeshub aeshub force-pushed the postgres-tests branch 5 times, most recently from 7ef4353 to ab69746 Compare January 21, 2025 12:26
aeshub
aeshub commented Jan 21, 2025
View reviewed changes
backend/api.test/Controllers/MissionSchedulingControllerTests.cs
@@ -272,7 +274,7 @@ await missionRunThreeResponse.Content.ReadFromJsonAsync<MissionRun>(
Assert.Equal(missionRunOne!.MissionId, activeMissionRun.MissionId);
Assert.Equal(missionRunTwo!.MissionId, activeMissionRun.MissionId);
Assert.Equal(missionRunThree!.MissionId, activeMissionRun.MissionId);
Assert.True(nextMissionRun.Id == missionRunOne.Id);
Assert.True(nextMissionRun.Id == missionRunTwo.Id);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this in a previous PR but had to change it back. Suspect this assert might be a bit dependent on luck.

@aeshub aeshub marked this pull request as ready for review January 22, 2025 11:47
Christdej
Christdej approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub aeshub merged commit fe8103a into equinor:main Jan 22, 2025
11 of 12 checks passed
@aeshub aeshub deleted the postgres-tests branch January 22, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

@aeshub aeshub

Labels
backend Backend related functionality database-change Will require migration feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeshub @Christdej