Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create consistent ordering of inspections #1065

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Create consistent ordering of inspections #1065

merged 1 commit into from
Nov 8, 2023

Conversation

andchiind
Copy link
Contributor

Closes #1062

@andchiind andchiind added the frontend Frontend related functionality label Oct 16, 2023
@andchiind andchiind self-assigned this Oct 16, 2023
@andchiind andchiind force-pushed the 1062-order-inspections branch from 9c6fbba to 4949973 Compare October 16, 2023 13:32
@andchiind andchiind force-pushed the 1062-order-inspections branch 2 times, most recently from 5274cf8 to 9cb0ca2 Compare October 17, 2023 10:18
aeshub
aeshub requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@andchiind andchiind force-pushed the 1062-order-inspections branch 3 times, most recently from e59c907 to 7b2ce7a Compare October 20, 2023 13:38
anetteu
anetteu reviewed Oct 29, 2023
View reviewed changes
Copy link
Member

@anetteu anetteu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read some of the sentences a few times before it was clear to me exactly what was written, and I have suggested a rewording. Please note that this was done sunday night, when neither my reading nor my writing was perfect 😄

frontend/src/components/Pages/InspectionPage/InspectionSection.tsx Outdated Show resolved Hide resolved
frontend/src/components/Pages/InspectionPage/InspectionSection.tsx Outdated Show resolved Hide resolved
@prasm313
Copy link
Contributor

Would suggest to move the red missions ("Not yet performed") to the top of the list.

@andchiind andchiind force-pushed the 1062-order-inspections branch 3 times, most recently from f606584 to a019852 Compare November 7, 2023 13:22
@andchiind
Copy link
Contributor Author

Would suggest to move the red missions ("Not yet performed") to the top of the list.

This is now the case
image

@andchiind andchiind force-pushed the 1062-order-inspections branch from a019852 to 8405d0c Compare November 7, 2023 14:50
mrica-equinor
mrica-equinor approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andchiind andchiind merged commit 1d31ae6 into equinor:main Nov 8, 2023
@andchiind andchiind deleted the 1062-order-inspections branch November 8, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anetteu anetteu anetteu left review comments

@eivindsjovold eivindsjovold eivindsjovold left review comments

@aeshub aeshub aeshub approved these changes

@mrica-equinor mrica-equinor mrica-equinor approved these changes

Assignees

@andchiind andchiind

Labels
frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missions on inspection plan change position every second or so
6 participants
@andchiind @prasm313 @aeshub @anetteu @eivindsjovold @mrica-equinor