Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement control scaling #9925

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Jan 30, 2025

Issue
Resolves #9835

Approach

Scaling is implement via a new variable transform approach in ropt, results should not affect current tests.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@verveerpj verveerpj self-assigned this Jan 30, 2025
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #9925 will not alter performance

Comparing reimplement-control-scaling (49dae10) with main (c6128f7)

Summary

✅ 25 untouched benchmarks

@verveerpj verveerpj force-pushed the reimplement-control-scaling branch from b62db17 to f90e19e Compare January 31, 2025 12:10
@verveerpj verveerpj force-pushed the reimplement-control-scaling branch 4 times, most recently from f58af29 to ad8013b Compare January 31, 2025 16:47
@verveerpj verveerpj force-pushed the reimplement-control-scaling branch from ad8013b to 49dae10 Compare January 31, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle autoscaling of controls in Everest
1 participant