Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq: make sure to destroy evaluator zmq context in case server fails on startup #9900

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Jan 29, 2025

Issue
Some tests were hanging due to the ee zmq context was not properly destroyed.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Jan 29, 2025
@jonathan-eq jonathan-eq self-requested a review January 29, 2025 09:05
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good findings! 🌊 🏄

@xjules xjules added zmq release-notes:skip If there should be no mention of this in release notes labels Jan 29, 2025
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #9900 will not alter performance

Comparing xjules:fix_zmq_hang (7e600dd) with main (cb0726d)

Summary

✅ 25 untouched benchmarks

@xjules xjules merged commit 63e5331 into equinor:main Jan 29, 2025
27 checks passed
@xjules xjules deleted the fix_zmq_hang branch January 29, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes zmq
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants