Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ErtConfig from EverestRunModel #9869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Jan 24, 2025

Issue
Resolves #9789

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 24, 2025

CodSpeed Performance Report

Merging #9869 will improve performances by 10.33%

Comparing frode-aarstad:remove-ert-config (347507a) with main (cb0726d)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 7 ms 6.3 ms +10.33%

@frode-aarstad frode-aarstad self-assigned this Jan 24, 2025
@frode-aarstad frode-aarstad force-pushed the remove-ert-config branch 3 times, most recently from 15834f2 to 986b1c5 Compare January 24, 2025 12:58
@frode-aarstad frode-aarstad changed the title first Remove ErtConfig from EverestRunModel Jan 24, 2025
@frode-aarstad frode-aarstad added the release-notes:refactor PR changes code without changing ANY (!) behavior. label Jan 24, 2025
result[variable.name].append(str(variable.index))
return dict(result)

# This adds an EXT_PARAM key to the ert_config, which is not a true ERT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code corresponding to this in everest_to_ert.py can be removed now that this is done here, as well as the test test_everest_to_ert_controls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:refactor PR changes code without changing ANY (!) behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ErtConfig from EverestRunModel
2 participants