Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add everest to rapid tests #9831

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 22, 2025

The additional time taken is ~5s due to xdist.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 22, 2025
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@eivindjahren eivindjahren enabled auto-merge (rebase) January 22, 2025 05:30
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9831 will degrade performances by 14%

Comparing eivindjahren:add_everest_to_rapid_tests (1ff21be) with main (3f61abe)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main eivindjahren:add_everest_to_rapid_tests Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.3 ms 1.5 ms -14%

@eivindjahren eivindjahren merged commit 15109bb into equinor:main Jan 22, 2025
32 of 33 checks passed
@eivindjahren eivindjahren deleted the add_everest_to_rapid_tests branch January 22, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants