Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ES_MDA as recommended algorithm in GUI #9828

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 21, 2025

Issue
Resolves backporting need

Approach
🍒 🌸

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:improvement Automatically categorise as improvement in release notes label Jan 21, 2025
Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #9828 will degrade performances by 82.65%

Comparing berland:version-12.1-esmdarec (a010628) with main (3f61abe)

Summary

❌ 2 regressions
✅ 22 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main berland:version-12.1-esmdarec Change
test_and_benchmark_adaptive_localization_with_fields 3 s 17.1 s -82.65%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_record_observations] 3.6 ms 4 ms -10.12%

@berland berland self-assigned this Jan 21, 2025
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@berland berland merged commit 416a1db into equinor:version-12.1 Jan 22, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants