Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport commits to version 12.1 #9827

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

jonathan-eq
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This commit fixes the issue where the rerun button was enabled for ES-MDA and ensemble smoother. The issue was due to us setting support_restart before calling the super class's constructor which overwrote it to False.
This commit makes the methods async, so we can await them instead
fire-and-forgetting them through asyncio.run_coroutine_threadsafe.
@jonathan-eq jonathan-eq requested a review from berland January 21, 2025 14:05
@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 21, 2025
Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #9827 will degrade performances by 82.56%

Comparing jonathan-eq:version-12.1 (d0d68d9) with main (a22c616)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jonathan-eq:version-12.1 Change
test_and_benchmark_adaptive_localization_with_fields 3 s 17 s -82.56%

@berland berland merged commit bc8a611 into equinor:version-12.1 Jan 21, 2025
40 of 41 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (bed9a2c) to head (d0d68d9).
Report is 2 commits behind head on version-12.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           version-12.1    #9827      +/-   ##
================================================
- Coverage         91.87%   91.84%   -0.03%     
================================================
  Files               433      433              
  Lines             26829    26820       -9     
================================================
- Hits              24648    24633      -15     
- Misses             2181     2187       +6     
Flag Coverage Δ
cli-tests 39.69% <76.92%> (-0.03%) ⬇️
everest-models-test 34.55% <46.15%> (-0.02%) ⬇️
gui-tests 72.12% <53.84%> (+0.01%) ⬆️
integration-test 38.65% <46.15%> (-0.03%) ⬇️
performance-tests 51.88% <46.15%> (-0.02%) ⬇️
test 40.02% <46.15%> (-0.06%) ⬇️
unit-tests 74.08% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants