Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where only literal error had position info #9826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features label Jan 21, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 21, 2025
Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #9826 will degrade performances by 10.74%

Comparing frode-aarstad:fix-validation-line-bug (cbf2d1c) with main (a22c616)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main frode-aarstad:fix-validation-line-bug Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.3 ms 1.4 ms -10.74%

@frode-aarstad frode-aarstad force-pushed the fix-validation-line-bug branch from 410b122 to cbf2d1c Compare January 21, 2025 13:59
DanSava
DanSava previously approved these changes Jan 22, 2025
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice fix 🧑‍🏭 but some tests are still failing.

@DanSava DanSava dismissed their stale review January 22, 2025 06:56

Tests still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:unreleased-bug-fix PR with a bug-fix of unreleased features
Projects
Status: Reviewed
Development

Successfully merging this pull request may close these issues.

2 participants