Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the run dialogue snappier by tuning batching interval #9824

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Make the run dialogue snappier by tuning batching interval #9824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ert/ensemble_evaluator/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def __init__(self, ensemble: Ensemble, config: EvaluatorServerConfig):
list[tuple[EVENT_HANDLER, Event]]
] = asyncio.Queue()
self._max_batch_size: int = 500
self._batching_interval: float = 2.0
self._batching_interval: float = 0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this, but the issue arises when having max running more than 200. Have you tried big poly with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try with bigpoly, but which issue or negative impact would you look for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance wise. That is whether it makes gui more or less responsive, since this gives more work to ee.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you flood the evaluator with messages (as in bigpoly), the parameter _max_batch_size will determine the behaviour (as far as I read the code), not the batching interval.

self._complete_batch: asyncio.Event = asyncio.Event()
self._server_started: asyncio.Event = asyncio.Event()
self._clients_connected: set[bytes] = set()
Expand Down
Loading