Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log dark storage info to terminal #9815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jan 20, 2025

Issue
Resolves #9707

Should hopefully not interfere with the propagation of dark storage logs to azure.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #9815 will not alter performance

Comparing larsevj:remove_openapi_logs_from_terminal (2666cb7) with main (fd06848)

Summary

✅ 24 untouched benchmarks

@larsevj larsevj requested a review from HakonSohoel January 21, 2025 10:58
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Jan 21, 2025
@larsevj larsevj requested a review from sondreso January 21, 2025 13:14
Copy link
Contributor

@HakonSohoel HakonSohoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

I've verified that dark storage logs are still propagated to azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI links are printed to stdout while starting Ert
2 participants