Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust the queue system when a job is finished in tests #9812

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 20, 2025

This avoids always spending 120 billable cpu-seconds on every test. Instead we trust that the queue system is correct when it claims a job is finished, instead of waiting it out.

Issue
Resolves overspending of github action runners.

Approach
⬆️

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This avoids always spending 120 billable cpu-seconds on every test.
Instead we trust that the queue system is correct when it claims a job
is finished, instead of waiting it out.
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #9812 will not alter performance

Comparing berland:dontwaitkilltest (3eb19a7) with main (fd06848)

Summary

✅ 24 untouched benchmarks

@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 21, 2025
@berland berland self-assigned this Jan 21, 2025
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏲️ 💵

@berland berland merged commit 61a6776 into equinor:main Jan 21, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants