Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim Ert workflows #9809

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

andreas-el
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el self-assigned this Jan 20, 2025
@andreas-el andreas-el added the release-notes:skip If there should be no mention of this in release notes label Jan 20, 2025
@andreas-el andreas-el changed the title Fix mac tests workflows Trim ert workflows Jan 20, 2025
@andreas-el andreas-el changed the title Trim ert workflows Trim Ert workflows Jan 20, 2025
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #9809 will improve performances by 10.58%

Comparing andreas-el:fix_mac_tests_workflows (503b3d8) with main (04ec9b4)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark main andreas-el:fix_mac_tests_workflows Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.5 ms 1.3 ms +10.58%

@andreas-el andreas-el enabled auto-merge (rebase) January 20, 2025 13:45
@andreas-el andreas-el disabled auto-merge January 20, 2025 13:47
@andreas-el andreas-el merged commit 0fcfca5 into equinor:main Jan 20, 2025
33 checks passed
@andreas-el andreas-el deleted the fix_mac_tests_workflows branch January 20, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants