Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up more tests #9803

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 20, 2025

Makes the fast tests run in roughly 20s.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #9803 will not alter performance

Comparing eivindjahren:speed_up_more_tests (e1c7bb8) with main (1528d2e)

Summary

✅ 24 untouched benchmarks

@eivindjahren eivindjahren self-assigned this Jan 20, 2025
@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 20, 2025
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ ⚡ ⚡

@eivindjahren eivindjahren merged commit 04ec9b4 into equinor:main Jan 20, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants