Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky prepost exp hook test #9785

Merged

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Jan 17, 2025

Resolves #9671
Not sure of the underlying cause for the flakiness, removing as it is already covered by test_model_hook_order

Copy link

codspeed-hq bot commented Jan 17, 2025

CodSpeed Performance Report

Merging #9785 will degrade performances by 10.68%

Comparing yngve-sk:25.01.17.mark-prepost-exp-hook-test-as-flaky (6720aab) with main (faf3d12)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main yngve-sk:25.01.17.mark-prepost-exp-hook-test-as-flaky Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.3 ms 1.4 ms -10.68%

@yngve-sk yngve-sk force-pushed the 25.01.17.mark-prepost-exp-hook-test-as-flaky branch from fcb957c to 79bf8e0 Compare January 17, 2025 12:16
@yngve-sk yngve-sk added the release-notes:skip If there should be no mention of this in release notes label Jan 17, 2025
@yngve-sk yngve-sk self-assigned this Jan 17, 2025
@yngve-sk yngve-sk force-pushed the 25.01.17.mark-prepost-exp-hook-test-as-flaky branch from 79bf8e0 to 7fb08b0 Compare January 20, 2025 13:00
@yngve-sk yngve-sk changed the title Mark prepost exp hook test as flaky Remove flaky prepost exp hook test Jan 20, 2025
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you just write in the commit body that this is already covered by test_hook_order?

@yngve-sk yngve-sk force-pushed the 25.01.17.mark-prepost-exp-hook-test-as-flaky branch 2 times, most recently from 9595709 to 660d487 Compare January 20, 2025 14:12
Already covered by test_hook_order
@yngve-sk yngve-sk force-pushed the 25.01.17.mark-prepost-exp-hook-test-as-flaky branch from 660d487 to 6720aab Compare January 20, 2025 14:13
@yngve-sk yngve-sk enabled auto-merge (squash) January 20, 2025 14:26
@yngve-sk yngve-sk merged commit fd06848 into equinor:main Jan 20, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

flaky tests/ert/ui_tests/cli/test_cli.py::::test_that_pre_post_experiment_hook_works
2 participants