Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace server_started Event with Future to handle exceptions #9749

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Jan 15, 2025

Issue
In a very special case zmq server might fail during initialization and all occurrences of server_started.wait() will wait indefinitely and therefore replacing it with asyncio.Future which provides additional exception trigger.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9749 will not alter performance

Comparing xjules:zmq_server_start (24635d0) with main (0b80ac1)

Summary

✅ 24 untouched benchmarks

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

In a very special case zmq server might fail during initialization and all occurrences of
server_started.wait() will wait indefinitely and therefore replacing it
with asyncio.Future which provides additional exception trigger.
@xjules xjules added the zmq label Jan 21, 2025
@xjules xjules merged commit 3f61abe into equinor:main Jan 21, 2025
33 checks passed
@xjules xjules deleted the zmq_server_start branch January 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants