Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate enum #9638

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Delete duplicate enum #9638

merged 2 commits into from
Jan 6, 2025

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jan 3, 2025

🧹

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (7e8d20c) to head (13fccf2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/libres_facade.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9638      +/-   ##
==========================================
- Coverage   91.74%   91.72%   -0.03%     
==========================================
  Files         430      429       -1     
  Lines       26639    26635       -4     
==========================================
- Hits        24440    24430      -10     
- Misses       2199     2205       +6     
Flag Coverage Δ
cli-tests 39.45% <90.00%> (-0.02%) ⬇️
everest-models-test 34.18% <50.00%> (-0.03%) ⬇️
gui-tests 71.82% <90.00%> (-0.04%) ⬇️
integration-test 38.29% <50.00%> (-0.01%) ⬇️
performance-tests 51.68% <90.00%> (-0.01%) ⬇️
test 39.61% <50.00%> (-0.01%) ⬇️
unit-tests 73.98% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #9638 will not alter performance

Comparing oyvindeide:add_breakthrough (13fccf2) with main (a372383)

Summary

✅ 24 untouched benchmarks

@oyvindeide oyvindeide self-assigned this Jan 6, 2025
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 6, 2025
Copy link
Contributor

@frode-aarstad frode-aarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing some enkf 🚀

@oyvindeide oyvindeide merged commit 790933d into equinor:main Jan 6, 2025
41 checks passed
@oyvindeide oyvindeide deleted the add_breakthrough branch January 6, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants