Use PySide6

[JHolba]

Upgrade from qtpy with pyqt5 to PySide6.
Using PySide6 directly should give us better typing.

• PR title captures the intent of the changes, and is fitting for release notes.
• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.
• Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

• When there are user facing changes: Updated documentation
• New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
• Large PR: Prepare changes in small commits for more convenient review
• Bug fix: Add regression test for the bug
• Bug fix: Create Backport PR to latest release

[codspeed-hq]

CodSpeed Performance Report

Merging #9586 will not alter performance

_{Comparing JHolba:use-pyside6 (d6b2e30) with main (8bdb398)}

Summary

✅ 24 untouched benchmarks

[jonathan-eq]

It fails locally on MacOS with python3.12, but I got it working by modifying:

@pytest.fixture
def panel_with_localization_on(qtbot: QtBot):
    def func(settings, ensemble_size):
        widget = AnalysisModuleVariablesPanel(settings, ensemble_size)
        qtbot.addWidget(widget)
        widget.show()
        check_box = widget.findChild(QCheckBox, name="localization")
        qtbot.mouseClick(check_box, Qt.MouseButton.LeftButton)
        return settings, widget

    yield func

[jonathan-eq]

When it failed it emitted:

---------------------------------------------------------------------------------------------------------------------------------------- Captured Qt messages ----------------------------------------------------------------------------------------------------------------------------------------
QtWarningMsg: Populating font family aliases took 77 ms. Replace uses of missing font family "Sans Serif" with one that exists to avoid this cost. 
QtWarningMsg: This plugin does not support propagateSizeHints()

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 85.58719% with 81 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (60fc8f8) to head (4d60c6e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ert/gui/simulation/run_dialog.py	67.74%	10 Missing ⚠️
src/ert/gui/model/node.py	76.31%	9 Missing ⚠️
src/ert/gui/tools/plugins/process_job_dialog.py	57.14%	9 Missing ⚠️
.../tools/plot/customize/limits_customization_view.py	52.94%	8 Missing ⚠️
.../ert/gui/tools/plot/widgets/clearable_line_edit.py	62.50%	6 Missing ⚠️
src/ert/gui/ertwidgets/searchbox.py	60.00%	4 Missing ⚠️
...t/gui/tools/plot/plot_ensemble_selection_widget.py	60.00%	4 Missing ⚠️
src/ert/gui/ertwidgets/listeditbox.py	72.72%	3 Missing ⚠️
.../gui/tools/plot/customize/customize_plot_dialog.py	82.35%	3 Missing ⚠️
src/ert/gui/ertwidgets/checklist.py	66.66%	2 Missing ⚠️
... and 15 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9586      +/-   ##
==========================================
- Coverage   91.68%   91.66%   -0.03%     
==========================================
  Files         424      424              
  Lines       26545    26576      +31     
==========================================
+ Hits        24339    24361      +22     
- Misses       2206     2215       +9     

Flag	Coverage Δ
cli-tests	39.78% <0.17%> (+0.03%)	⬆️
everest-models-test	34.08% <0.17%> (-0.02%)	⬇️
gui-tests	74.23% <79.89%> (-0.05%)	⬇️
integration-test	37.97% <0.17%> (-0.02%)	⬇️
performance-tests	51.52% <58.18%> (-0.01%)	⬇️
test	39.29% <0.17%> (-0.03%)	⬇️
unit-tests	74.20% <72.06%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JHolba]

It fails locally on MacOS with python3.12, but I got it working by modifying:

@pytest.fixture
def panel_with_localization_on(qtbot: QtBot):
    def func(settings, ensemble_size):
        widget = AnalysisModuleVariablesPanel(settings, ensemble_size)
        qtbot.addWidget(widget)
        widget.show()
        check_box = widget.findChild(QCheckBox, name="localization")
        qtbot.mouseClick(check_box, Qt.MouseButton.LeftButton)
        return settings, widget

    yield func

Thank you for the help :)

[jonathan-eq]

Why are we checking if it is not None, if the parameter cannot be None?

[jonathan-eq]

Very good! I have some questions, see comments :)