Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send analysis time updates every second #9034

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 24, 2024

Backport of #8942

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 24, 2024
@sondreso sondreso enabled auto-merge (rebase) October 24, 2024 10:31
@sondreso sondreso merged commit 50f9efe into equinor:version-11.0 Oct 24, 2024
34 of 35 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (e47bc09) to head (4b1ab6b).
Report is 1 commits behind head on version-11.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           version-11.0    #9034      +/-   ##
================================================
+ Coverage         91.41%   91.42%   +0.01%     
================================================
  Files               343      343              
  Lines             21331    21335       +4     
================================================
+ Hits              19499    19505       +6     
+ Misses             1832     1830       -2     
Flag Coverage Δ
cli-tests 38.98% <60.00%> (+0.01%) ⬆️
gui-tests 72.41% <60.00%> (+0.01%) ⬆️
performance-tests 49.23% <100.00%> (-0.03%) ⬇️
unit-tests 80.00% <20.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren deleted the backport_analysis_timed_update branch October 24, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants