Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConfigWarning not calling class method of child classes #8845

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Oct 2, 2024

This commit fixes an issue where the parent class ConfigWarning has all methods decorated with staticmethod, rather than classmethod. The class methods should call the child class's method implementation where they are implemented.

Approach
🏎️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This commit fixes an issue where the parent class `ConfigWarning` has all methods decorated with `staticmethod`, rather than `classmethod`. The class methods should call the child class's method implementation where they are implemented.
@jonathan-eq jonathan-eq added the release-notes:misc Automatically categorise as miscellaneous change in release notes label Oct 2, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (4321e49) to head (2ea48fb).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8845   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         342      343    +1     
  Lines       21034    21086   +52     
=======================================
+ Hits        19226    19274   +48     
- Misses       1808     1812    +4     
Flag Coverage Δ
cli-tests 39.62% <77.77%> (-0.01%) ⬇️
gui-tests 73.50% <100.00%> (-0.06%) ⬇️
performance-tests 50.16% <77.77%> (-0.07%) ⬇️
unit-tests 79.88% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan-eq jonathan-eq merged commit f6b86c6 into equinor:main Oct 2, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:misc Automatically categorise as miscellaneous change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants