Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ORCID domains from DESCRIPTION #126

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove ORCID domains from DESCRIPTION #126

merged 1 commit into from
Feb 12, 2024

Conversation

chartgerink
Copy link
Member

Hi 👋 I noticed while reviewing the vaccineff package that there were issues with the URLs from the website. More specifically, the URLs look like this: https://orcid.org/https://orcid.org/0000-0002-8165-3198 (see also epiverse-trace/vaccineff#39)

It seems like the template is prescribing a faulty (and inconsistent) way to include ORCIDs. This PR updates the template description accordingly.

@chartgerink chartgerink requested a review from Bisaloo February 12, 2024 09:42
@Bisaloo
Copy link
Member

Bisaloo commented Feb 12, 2024

Thanks for the catch! It looks like CRAN accepts both formats, but pkgdown websites don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants